Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys/embunit: return failure state in TextUIRunner_end() #20535

Merged
merged 1 commit into from
Apr 3, 2024
Merged

sys/embunit: return failure state in TextUIRunner_end() #20535

merged 1 commit into from
Apr 3, 2024

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Apr 3, 2024 •
edited
Loading

Contribution description

Testing procedure

OUTPUT="TEXT" make -C tests/unittest should work again

Issues/PRs references

follow-up to #20445

@benpicco benpicco marked this pull request as ready for review April 3, 2024 11:23
@github-actions github-actions bot added the Area: sys Area: System label Apr 3, 2024
@benpicco benpicco requested a review from Teufelchen1 April 3, 2024 11:24
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Apr 3, 2024
@benpicco benpicco requested a review from kaspar030 April 3, 2024 11:25
Teufelchen1
Teufelchen1 approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@Teufelchen1 Teufelchen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Did you also test color output and xml?

@benpicco
Copy link
Contributor Author

benpicco commented Apr 3, 2024

We have color output and XML?

@Teufelchen1
Copy link
Contributor

Yes see embUnit.h

In anyway, both seem to be not affected, this can be merged once murdock is happy.

@riot-ci
Copy link

riot-ci commented Apr 3, 2024 •
edited
Loading

Murdock results

✔️ PASSED

127a290 sys/embunit: return failure state in TextUIRunner_end()

Success Failures Total Runtime
10027 0 10027 11m:36s

Artifacts

@benpicco benpicco added this pull request to the merge queue Apr 3, 2024
@benpicco benpicco added Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Apr 3, 2024
Merged via the queue into RIOT-OS:master with commit 255a692 Apr 3, 2024
29 checks passed
@benpicco benpicco deleted the TextUIRunner_end-return branch April 3, 2024 17:46
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.04 milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Teufelchen1 Teufelchen1 Teufelchen1 approved these changes

@kaspar030 kaspar030 Awaiting requested review from kaspar030

Assignees
No one assigned
Labels
Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2024.04
Development

Successfully merging this pull request may close these issues.
4 participants
@benpicco @Teufelchen1 @riot-ci @MrKevinWeiss